mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshi Xiao <xia...@gmail.com>
Subject Re: Review Request 45500: Keep fs::mount information should be consolidated.
Date Tue, 12 Apr 2016 11:49:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
-----------------------------------------------------------

(Updated 四月 12, 2016, 11:49 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
    https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
-------

keep fs::mount information should be consolidated and moved to stout,
along with mount and umount.

Refers to Benjamin Hindman's TODO:
https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64


Diffs (updated)
-----

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
  src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf


Diff: https://reviews.apache.org/r/45500/diff/


Testing
-------

make test on localhost(ubuntu)


Thanks,

Deshi Xiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message