mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.
Date Tue, 12 Apr 2016 02:11:51 GMT


> On April 11, 2016, 7 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 198
> > <https://reviews.apache.org/r/45954/diff/2/?file=1338335#file1338335line198>
> >
> >     Please stick to our style guide by moving '{' to the next line.

Removed this structure. Without the need to read the mount table, we don't need to store mount
entries, so this structure becomes redundant.


> On April 11, 2016, 7 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1172-1192
> > <https://reviews.apache.org/r/45954/diff/2/?file=1338336#file1338336line1172>
> >
> >     Why do you need to read the mount table? Does seem to be necessary to me.

Removed this code.


> On April 11, 2016, 7 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1239-1243
> > <https://reviews.apache.org/r/45954/diff/2/?file=1338336#file1338336line1239>
> >
> >     Let's do ll the sanity checks before we actually doing the work.
> >     
> >     Also, can we do the setns together in one place. I would suggest not splitting
into 'hostname' and 'mount' helpers. Let's just put all logics in 'execute'.

Re-factored the code to remove `hostname()` and `mount()`.


> On April 11, 2016, 7 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1285-1291
> > <https://reviews.apache.org/r/45954/diff/2/?file=1338336#file1338336line1285>
> >
> >     We cannot bindly call os::touch here. Let's just assume the mount point exists
for now (just do os::exists check).

Keeping this code as per our discussion. Since these files might not exist in the container
filesystem.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45954/#review128168
-----------------------------------------------------------


On April 12, 2016, 2:09 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45954/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
>     https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `subcommand` allow configuring the container hostname and setting
> up network files in the container such as /etc/hosts, /etc/hostname,
> /etc/resolv.conf. This will allow for correct name to IP resolution
> within the container network namespace.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c

> 
> Diff: https://reviews.apache.org/r/45954/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> * Ran mesos_execute along with a single master/slave setup to verify that the container
joins the CNI network and the hostname and /etc/hosts, /etc/resolv.conf are setup correctly.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message