mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.
Date Tue, 12 Apr 2016 00:13:20 GMT


> On April 11, 2016, 10:44 p.m., Ben Mahler wrote:
> > Mind doing a sweep for this?

I noticed a few more candidates in `futures_test.cpp` and added them to the RR; I didn't try
to look beyond the libprocess tests.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/#review128274
-----------------------------------------------------------


On April 11, 2016, 9:01 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46029/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also, remove two unused includes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp e8ee8ee01ee9524b308452c403326e10f75b3ce5

> 
> Diff: https://reviews.apache.org/r/46029/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message