mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.
Date Mon, 11 Apr 2016 21:53:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46044/#review128265
-----------------------------------------------------------




src/cli/execute.cpp 
<https://reviews.apache.org/r/46044/#comment191684>

    I like the idea of simplifying the ctor. I am not too excited about the idea of moving
everything to 'flag'. A `CommandScheduler` object should have some properties like `command`,
`master`, `name`. Others like 'image' information should be moved to its own class/struct
(say `ContainerInfo`). Just my 2 cents.


- Jojy Varghese


On April 11, 2016, 7:01 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46044/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass complete `flags` instance rather than each flag value separately
> to `CommandScheduler` in mesos-execute for brevity.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 
> 
> Diff: https://reviews.apache.org/r/46044/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> make check
> 
> Additionally manually tested mesos-execute with both responsive and unresponsive (https://github.com/rukletsov/unresponsive-process)
tasks:
> ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" --env='{"GLOG_v":
"2"}' --kill_after=2secs
> ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="/Users/alex/bin/unresponsive_process"
--env='{"GLOG_v": "2"}' --kill_after=2secs
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message