mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45956: Added the `_isolate` method.
Date Mon, 11 Apr 2016 19:10:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/#review128211
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 674)
<https://reviews.apache.org/r/45956/#comment191601>

    .then in the next line.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 717 - 720)
<https://reviews.apache.org/r/45956/#comment191602>

    Can you use stout IPNetwork::parse first and get IP using 'IPNetwork::address()'



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 762)
<https://reviews.apache.org/r/45956/#comment191603>

    I don't think 'realpath' is necessary here.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 797 - 823)
<https://reviews.apache.org/r/45956/#comment191604>

    Please follow style in 'attach' to monitor the subprocess outputs.


- Jie Yu


On April 9, 2016, 5:48 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45956/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4922
>     https://issues.apache.org/jira/browse/MESOS-4922
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once the `isolate` is successful, the `_isolate` method calls out the
> `mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
> /etc/resolv.conf for the container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c

> 
> Diff: https://reviews.apache.org/r/45956/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> *Ran mesos_execute with single master/slave setup to verify that containers get the right
hostname and network files when attached to a CNI network.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message