mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 45604: Updated the balloon framework and executor.
Date Mon, 11 Apr 2016 18:24:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/
-----------------------------------------------------------

(Updated April 11, 2016, 11:24 a.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Changes
-------

Added JIRA with summary of problems found while deploying this framework.


Bugs: MESOS-5174
    https://issues.apache.org/jira/browse/MESOS-5174


Repository: mesos


Description
-------

This gives the example `balloon-framework` enough options to run
outside of the build environment.

This also updates:

* The style of the framework code.
* Adds an option for restricting the number of resources per task
  (otherwise, it will eat up an entire node).
* Adds an option for persisting the framework and launching one task
  after another.
* Adds filters for declined offers.
* Refines the shutdown logic for the executor.  In particular, ironed 
  out bugs when the balloon executor does not exceed the memory limit.


Diffs
-----

  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 

Diff: https://reviews.apache.org/r/45604/diff/


Testing
-------

```
make check 

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message