mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45562: Edited `--work_dir` configuration docs.
Date Mon, 11 Apr 2016 16:42:36 GMT


> On March 31, 2016, 10:16 p.m., Joerg Schad wrote:
> > docs/configuration.md, line 354
> > <https://reviews.apache.org/r/45562/diff/3/?file=1321440#file1321440line354>
> >
> >     Not yours but why isn't that flag in the common master/agent section above?

I decided to put the work_dir flags in the "required flags" section of the master/agent (since
they're required), rather than the "shared flags" section. What do you think?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
-----------------------------------------------------------


On April 11, 2016, 4:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
>     https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some users have encountered difficulty when running the Mesos agent with the `work_dir`
located in a subdirectory of `/tmp`. This patch adds language to the `work_dir` help strings
and configuration docs advising users to avoid the use of this location in production.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message