mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 45863: Updated error messages in weights handler.
Date Mon, 11 Apr 2016 14:48:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/
-----------------------------------------------------------

(Updated April 11, 2016, 2:48 p.m.)


Review request for mesos, Yongqiao Wang and Joerg Schad.


Repository: mesos


Description
-------

While writing log or error messages we adhere the following style:
  * No period at the end (there are exceptions though, e.g., one is
    when constructing request responses.
  * When splitting a string over multiple lines, put a space at the
    beginning of the following line in contrast to the end of the
    previous line.


Diffs (updated)
-----

  src/master/weights_handler.cpp 10a1fbc5656f98bc893cf63f2653565ae7ebd125 

Diff: https://reviews.apache.org/r/45863/diff/


Testing
-------

On Mac OS 10.10.4: 
`make check`


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message