mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <>
Subject Re: Review Request 45200: Duplicate flags with keyword 'slave'.
Date Mon, 11 Apr 2016 06:45:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 11, 2016, 6:45 a.m.)

Review request for mesos and Vinod Kone.

Summary (updated)

Duplicate flags with keyword 'slave'.

Repository: mesos

Description (updated)

It duplicates master/slave flags that contain 'slave'. This is
part of the epic replacing all keyword 'slave' with 'agent' in
current codebase.

Diffs (updated)

  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  src/ dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
  src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
  src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
  src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
  src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
  src/tests/flags_tests.cpp PRE-CREATION 


Testing (updated)

./configure --with-network-isolator
make check (on OSX and Ubuntu)


Jay Guo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message