mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45950: Added test for docker spec get credential helper.
Date Mon, 11 Apr 2016 05:20:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45950/#review128042
-----------------------------------------------------------




src/tests/containerizer/docker_spec_tests.cpp (lines 196 - 197)
<https://reviews.apache.org/r/45950/#comment191437>

    Merge those two lines to the following?
    
    EXPECT_SOME_EQ("bWVzb3M6dGVzdA==", auth);
    
    Ditto for the following



src/tests/containerizer/docker_spec_tests.cpp (lines 196 - 197)
<https://reviews.apache.org/r/45950/#comment191438>

    EXPECT_SOME_EQ("bWVzb3M6dGVzdA==", auth);
    
    Ditto for the following


- Guangya Liu


On 四月 8, 2016, 9:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45950/
> -----------------------------------------------------------
> 
> (Updated 四月 8, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for docker spec get credential helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_spec_tests.cpp 796b020f58f8451362bc1357ab6d7ceb4e946b3c

> 
> Diff: https://reviews.apache.org/r/45950/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message