mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.
Date Sun, 10 Apr 2016 13:32:36 GMT


> On April 10, 2016, 12:31 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [43477, 43475, 43474, 43473, 43472, 43471]
> > 
> > Failed command: ./support/apply-review.sh -n -r 43471
> > 
> > Error:
> > 2016-04-10 12:31:44 URL:https://reviews.apache.org/r/43471/diff/raw/ [3615/3615]
-> "43471.patch" [1]
> > 43471.patch:23: trailing whitespace.
> >  
> > 43471.patch:27: trailing whitespace.
> >  
> > 43471.patch:62: trailing whitespace.
> >  
> > 43471.patch:66: trailing whitespace.
> >  
> > 43471.patch:76: trailing whitespace.
> >      /* We queued the buffer, so don't free it */   
> > warning: 5 lines add whitespace errors.
> > 3rdparty/zookeeper-06d3f3f.patch:212: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-06d3f3f.patch:216: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:34: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:38: trailing whitespace.
> > + 
> > 3rdparty/zookeeper-3.4.8.patch:48: trailing whitespace.
> > +     /* We queued the buffer, so don't free it */   
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/12442/console

Hmm, if remove these whitespace, the `zookeeper-3.4.8.patch` could not apply successfully.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43477/#review128032
-----------------------------------------------------------


On April 10, 2016, 10:19 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43477/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4648
>     https://issues.apache.org/jira/browse/MESOS-4648
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up GroupTest.* test cases by advance clock.
> 
> 
> Diffs
> -----
> 
>   src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
> 
> Diff: https://reviews.apache.org/r/43477/diff/
> 
> 
> Testing
> -------
> 
> Test repeatly in CentOS 7.1
> 
> ```
>  sudo ./bin/mesos-tests.sh --gtest_filter="GroupTest.*" --verbose --gtest_repeat=200
--gtest_break_on_failure
> ```
> 
> Before
> 
> ```
> [       OK ] GroupTest.GroupJoinWithDisconnect (3352 ms)
> [       OK ] GroupTest.GroupDataWithDisconnect (3350 ms)
> [       OK ] GroupTest.GroupCancelWithDisconnect (2013 ms)
> [       OK ] GroupTest.GroupPathWithRestrictivePerms (13368 ms)
> [       OK ] GroupTest.RetryableErrors (26720 ms)
> ```
> 
> After 
> 
> ```
> [       OK ] GroupTest.GroupJoinWithDisconnect (405 ms)
> [       OK ] GroupTest.GroupDataWithDisconnect (192 ms)
> [       OK ] GroupTest.GroupCancelWithDisconnect (250 ms)
> [       OK ] GroupTest.GroupPathWithRestrictivePerms (334 ms)
> [       OK ] GroupTest.RetryableErrors (341 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message