mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43474: Speed up MasterDetectorExpireSlaveZKSession by advance Clock.
Date Sun, 10 Apr 2016 10:18:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43474/
-----------------------------------------------------------

(Updated April 10, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
-------

Update according to @alexr's comments.


Bugs: MESOS-4651
    https://issues.apache.org/jira/browse/MESOS-4651


Repository: mesos


Description
-------

Speed up MasterDetectorExpireSlaveZKSession by advance Clock.


Diffs (updated)
-----

  src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/43474/diff/


Testing (updated)
-------

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh --gtest_filter="ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession"
--verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[       OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession (3358
ms)
```

After 

```
[       OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession (448
ms)
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message