mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.
Date Sun, 10 Apr 2016 00:39:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45943/#review128007
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 87)
<https://reviews.apache.org/r/45943/#comment191409>

    This __NOTE__ should move to `posix/pagesize.hpp` or be removed.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp (line 23)
<https://reviews.apache.org/r/45943/#comment191408>

    `= {0};` only initializes the first member of the struct, it does __not__ zero-initialize
the struct. Is this what we want?
    
    Do we need to initialize this at all? `GetSystemInfo` is going to write to it anyway.
    
    If we want to be explicit, and zero-initialize, we should do `= {}`.


- Michael Park


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45943/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
>     https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6606e60266d003bbce38bb7cff103ffb603de315

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 6b81bf1ea3d571e8f5fb170076b85223b02efe2c

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 182ac9cfbacd4535fb355aac6ec38559d786e63a

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/45943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message