mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.
Date Sat, 09 Apr 2016 00:16:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review127918
-----------------------------------------------------------



Looks pretty good, thanks!

Could you also add tests that mirror the task label tests?

```
$ grep -R TEST src/tests | grep TaskLabels
src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels)
src/tests/slave_tests.cpp:TEST_F(SlaveTest, TaskLabels)
```


CHANGELOG (lines 49 - 50)
<https://reviews.apache.org/r/45572/#comment191292>

    The ExecutorInfo.source deprecation should be mentioned in the 'Deprecations' section.
I would ok duplicating this in both sections, and only calling out the labels in the 'Additional
API Changes' section.



include/mesos/mesos.proto (line 473)
<https://reviews.apache.org/r/45572/#comment191297>

    No need to bother renaming slave to agent in the pre-V1 API.



include/mesos/mesos.proto (line 478)
<https://reviews.apache.org/r/45572/#comment191304>

    All comments should end with a period, I guess you may have copied this from code that
didn't follow that style.



include/mesos/mesos.proto (lines 496 - 498)
<https://reviews.apache.org/r/45572/#comment191311>

    Any reason not to re-use the more descriptive comment on TaskInfo.labels? Specifically
it would be nice to include the warning about the master keeping this data in memory.


- Ben Mahler


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
>     https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> -------
> 
> Added a test in oversubciption_tests to make sure executor labels are visible to ResourceEstimator
and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message