mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
Date Fri, 08 Apr 2016 23:48:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/#review127926
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.cpp (line 81)
<https://reviews.apache.org/r/44090/#comment191307>

    Let's use `reinterpret_cast<const char *>(...)`.



3rdparty/libprocess/src/poll_socket.cpp (line 118)
<https://reviews.apache.org/r/44090/#comment191308>

    Let's use `reinterpret_cast<char *>(...)`.



3rdparty/libprocess/src/poll_socket.cpp (lines 160 - 166)
<https://reviews.apache.org/r/44090/#comment191309>

    We'll follow-up with patches to add the following functions and use them here:
    
    ```
    Try<ssize_t, SocketError> network::send(...);
    Try<ssize_t, SocketError> network::recv(...);
    ```


- Michael Park


On April 8, 2016, 9:38 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44090/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer,
Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Changed the calling parameters for Windows API.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
>   3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/44090/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message