mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.
Date Fri, 08 Apr 2016 23:00:03 GMT


> On April 8, 2016, 10:55 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 123
> > <https://reviews.apache.org/r/45668/diff/3/?file=1337709#file1337709line123>
> >
> >     Remove the trailing white space and put a period at the end. Also wrap at 80
chars.
> >     
> >     Also I would rephrase this as follows:
> >     
> >     # Building inside the source directory and distcheck are not currently supported

> >     # by our CMake scripts. See MESOS-3108 for details.

Also, can you rebase?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
-----------------------------------------------------------


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools.
In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message