mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.
Date Fri, 08 Apr 2016 22:50:38 GMT


> On April 4, 2016, 5:26 p.m., haosdent huang wrote:
> > CHANGELOG, line 49
> > <https://reviews.apache.org/r/45572/diff/1/?file=1321727#file1321727line49>
> >
> >     Usually we don't need change file. It would be changed by release manager.
> 
> Zhitao Li wrote:
>     hmm, right now the top section of CHANGELOG is written by each feature author in
git blame, and this was also my impression that we should collectively help on changelog documentation
so work load of release manager can be reduced.
>     
>     Please let me know if my understanding of the process is incorrect and I'll happily
drop this change.

We do want contributors adding to the CHANGELOG deprecations / api changes / etc. It is difficult
for release managers to do a good job at it given how many commits are in a release.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126862
-----------------------------------------------------------


On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5029
>     https://issues.apache.org/jira/browse/MESOS-5029
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add labels to ExecutorInfo and deprecate source.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
>   src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
> 
> Diff: https://reviews.apache.org/r/45572/diff/
> 
> 
> Testing
> -------
> 
> Added a test in oversubciption_tests to make sure executor labels are visible to ResourceEstimator
and QoSController.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message