mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 45670: Added tests for HTTP command executor.
Date Fri, 08 Apr 2016 22:49:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review127907
-----------------------------------------------------------



Looks good. Just some minor comments about handling the parameterization in test body.


src/tests/command_executor_tests.cpp (line 62)
<https://reviews.apache.org/r/45670/#comment191276>

    How about:
    
    ```cpp
    // The Command Executor tests are parameterized by the underlying library used by the
executor (e.g., driver or the HTTP based executor library).
    ```



src/tests/command_executor_tests.cpp (line 64)
<https://reviews.apache.org/r/45670/#comment191277>

    s/HttpBasedExecutor/ExecutorType



src/tests/command_executor_tests.cpp (line 78)
<https://reviews.apache.org/r/45670/#comment191280>

    How about:
    
    ```cpp
    slave::Flags flags = CreateSlaveFlags();
    flags.http_command_executor = GetParam();
    
    Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), flags);
    ASSERT_SOME(slave);
    ```



src/tests/command_executor_tests.cpp (lines 80 - 85)
<https://reviews.apache.org/r/45670/#comment191278>

    Kill this



src/tests/command_executor_tests.cpp (line 148)
<https://reviews.apache.org/r/45670/#comment191281>

    Ditto as above.



src/tests/command_executor_tests.cpp (lines 150 - 155)
<https://reviews.apache.org/r/45670/#comment191279>

    Kill this


- Anand Mazumdar


On April 7, 2016, 1:49 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 1:49 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message