> On April 8, 2016, 7:11 p.m., Vinod Kone wrote:
> > src/examples/long_lived_framework.cpp, lines 136-149
> > <https://reviews.apache.org/r/45910/diff/1/?file=1331774#file1331774line136>
> >
> > I'm still not convinced that duplicating this information in /metrics/snashot
and /counters is a great idea. We haven't done this for other metrics in the code base.
> >
> > Is it a limitation of the monitoring system you are using that disallows it
to slurp both counters and gauges from the same endpoint?
>
> Joseph Wu wrote:
> There is no duplication here. (The `/counters` endpoint doesn't give metrics, only
the name of metrics.)
>
> As for the monitoring system, there are a couple types of queries which assume a
monotonically increasing value (counters). So the data is less useful if we cannot differentiate
between counters/gauges. For now, this code isn't super-critical, so I'll remove it here.
>
> Do you want me to remove it from the earlier review too?
just removing here is fine.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127845
-----------------------------------------------------------
On April 8, 2016, 8:29 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 8:29 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the HTTP scheduler is a libprocess process, the sub-class
> `Metrics` does not need to be a process anymore. This moves the
> process-specific code into the appropriate place in the scheduler.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45910/diff/
>
>
> Testing
> -------
>
> make check
>
> Deployed on a test cluster (see the first review in the chain.)
>
>
> Thanks,
>
> Joseph Wu
>
>
|