mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45440: Added some metrics to the long-lived-framework example.
Date Fri, 08 Apr 2016 19:12:31 GMT


> On April 6, 2016, 6:55 p.m., Vinod Kone wrote:
> >
> 
> Vinod Kone wrote:
>     As discussed offline, lets add TODOs for metrics to defer the gauges to scheduler
process.

Mark the issues as fixed here, so that we can focus the discussion on the last review in the
chain.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127404
-----------------------------------------------------------


On April 6, 2016, 11:19 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45440/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5062
>     https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * offers_received = A counter used to determine if the framework is 
>   starved or not.
> * tasks_launched = Number of tasks launched.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED`.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45440/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also deployed this version on a test cluster.  See the previous review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message