-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127845
-----------------------------------------------------------
src/examples/long_lived_framework.cpp (lines 132 - 145)
<https://reviews.apache.org/r/45910/#comment191218>
I'm still not convinced that duplicating this information in /metrics/snashot and /counters
is a great idea. We haven't done this for other metrics in the code base.
Is it a limitation of the monitoring system you are using that disallows it to slurp both
counters and gauges from the same endpoint?
src/examples/long_lived_framework.cpp (line 446)
<https://reviews.apache.org/r/45910/#comment191217>
seems weird for this to be a gauge when this is actually a counter.
just do, ++metrics.tasks_launched in launch().
- Vinod Kone
On April 8, 2016, 12:02 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the HTTP scheduler is a libprocess process, the sub-class
> `Metrics` does not need to be a process anymore. This moves the
> process-specific code into the appropriate place in the scheduler.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45910/diff/
>
>
> Testing
> -------
>
> make check
>
> Deployed on a test cluster (see the first review in the chain.)
>
>
> Thanks,
>
> Joseph Wu
>
>
|