mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45927: Introduced kill task delay in mesos-execute.
Date Fri, 08 Apr 2016 16:54:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45927/#review127815
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45925, 45926, 45927]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45927/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5124
>     https://issues.apache.org/jira/browse/MESOS-5124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a flag that specifies a delay after which the task should be
> killed. If set, a kill task request is scheduled to be sent after
> TASK_RUNNING status update has been received. Also adds support for
> TASK_KILLING capability.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45927/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `make check`
> 
> Additionally manually tested `mesos-execute` with both responsive and unresponsive (https://github.com/rukletsov/unresponsive-process)
tasks:
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" --env='{"GLOG_v":
2}'`
> `./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="/Users/alex/bin/unresponsive_process"
--env='{"GLOG_v": 2}'`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message