mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Date Fri, 08 Apr 2016 06:49:24 GMT


> On April 8, 2016, 6:41 a.m., Shuai Lin wrote:
> > 3rdparty/libprocess/include/process/collect.hpp, line 217
> > <https://reviews.apache.org/r/45083/diff/8/?file=1329609#file1329609line217>
> >
> >     Got a compile error here:
> >     
> >     
> >     ```
> >     In file included from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:19:
> >     ../../../3rdparty/libprocess/include/process/collect.hpp:216:24: error: redefinition
of default argument
> >         const CollectMode& mode = CollectMode::ALL)
> >                            ^      ~~~~~~~~~~~~~~~~
> >     ../../../3rdparty/libprocess/include/process/collect.hpp:51:24: note: previous
definition is here
> >         const CollectMode& mode = CollectMode::ALL);
> >     ```
> >     
> >     After remvoe the default argument value in line 216 it compiles ok.

On ubuntu with g++ it works fine, but fails on osx with clang.


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/#review127744
-----------------------------------------------------------


On April 7, 2016, 10:36 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45083/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 10:36 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5038
>     https://issues.apache.org/jira/browse/MESOS-5038
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added ANY mode to futures collect mechanism.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc

>   3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401

> 
> Diff: https://reviews.apache.org/r/45083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message