mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45910: Move metrics code into the scheduler body.
Date Fri, 08 Apr 2016 02:53:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127722
-----------------------------------------------------------



Bad patch!

Reviews applied: [45910, 45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-08 02:53:42 URL:https://reviews.apache.org/r/45067/diff/raw/ [13287/13287] -> "45067.patch"
[1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12398/console

- Mesos ReviewBot


On April 8, 2016, 12:02 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
>     https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the HTTP scheduler is a libprocess process, the sub-class 
> `Metrics` does not need to be a process anymore.  This moves the
> process-specific code into the appropriate place in the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45910/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Deployed on a test cluster (see the first review in the chain.)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message