mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45905: Added metrics to the balloon framework.
Date Fri, 08 Apr 2016 02:24:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/#review127719
-----------------------------------------------------------



Bad patch!

Reviews applied: [45905, 45604]

Failed command: ./support/apply-review.sh -n -r 45604

Error:
2016-04-08 02:24:27 URL:https://reviews.apache.org/r/45604/diff/raw/ [18869/18869] -> "45604.patch"
[1]
Total errors found: 0
Checking 2 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12397/console

- Mesos ReviewBot


On April 7, 2016, 10:59 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45905/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * tasks_finished = Number of tasks finished (successfully).
> * tasks_oomed = Number of tasks that were OOM killed.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
> 
> Diff: https://reviews.apache.org/r/45905/diff/
> 
> 
> Testing
> -------
> 
> ```
> make check
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> 
> # Also launched two instances on a cluster.
> # This one OOM's:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=128MB --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"
> 
> # This one does not OOM:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=256MB --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message