mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.
Date Thu, 07 Apr 2016 22:13:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------




support/docker_build.sh (line 10)
<https://reviews.apache.org/r/45668/#comment191060>

    s/CONFIGURATOR/BUILDTOOL/



support/docker_build.sh (line 16)
<https://reviews.apache.org/r/45668/#comment191062>

    the previous version was working fine on ubuntu and centos. why the change?



support/docker_build.sh 
<https://reviews.apache.org/r/45668/#comment191063>

    we leave 2 blank lines between outer elements. why the change?



support/docker_build.sh (line 114)
<https://reviews.apache.org/r/45668/#comment191064>

    How about
    
    # NOTE: Enviornment is currently ignored by CMake build because tests are not run.



support/docker_build.sh (line 123)
<https://reviews.apache.org/r/45668/#comment191065>

    indent the comment with the line below.



support/docker_build.sh (line 124)
<https://reviews.apache.org/r/45668/#comment191067>

    s/mesos-cmake/build/



support/docker_build.sh (line 127)
<https://reviews.apache.org/r/45668/#comment191066>

    s/Configurator/build tool/


- Vinod Kone


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools.
In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message