mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45494: Removed clone option from subprocess [4/5].
Date Thu, 07 Apr 2016 18:33:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45494/#review127637
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess.cpp (line 561)
<https://reviews.apache.org/r/45494/#comment191022>

    May I ask why open update `clone` in linux when `clone_flags.isSome()`? As you see in
the old version code, it update `clone` without care about the platform?
    
    And if we really only want to update `clone` in linxu, may we add a error log here if
`clone_flags.isSome()` in other platforms?


- haosdent huang


On April 7, 2016, 5:07 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45494/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 5:07 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5071
>     https://issues.apache.org/jira/browse/MESOS-5071
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As we now support namespaces in the subprocess there should be no need
> for custom clone functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 8a3fe5526f480187441a8aee2c72636bec3e2b2d

>   3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
> 
> Diff: https://reviews.apache.org/r/45494/diff/
> 
> 
> Testing
> -------
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message