mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <>
Subject Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.
Date Thu, 07 Apr 2016 18:23:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 7, 2016, 6:23 p.m.)

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.

Bugs: MESOS-4415

Repository: mesos


We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
This API is incompatible with NT paths -- which we will eventually have
to transition to for the Windows integration -- and has no documented
behavior interacting with subsystems like the driver subsystem, which is
required for symlinks.

This commit will move us to proper core Windows API equivalents for


Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/ 54dd3f7e1453a756e10652cebf4c2a2b09e3d5a4

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 52568b303c03fd57b81f6cc67782444ce734dd41

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83




Alex Clemmer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message