mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 45492: Used ChildHooks in Mesos [2/5].
Date Thu, 07 Apr 2016 16:58:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45492/
-----------------------------------------------------------

(Updated April 7, 2016, 4:58 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5070
    https://issues.apache.org/jira/browse/MESOS-5070


Repository: mesos


Description
-------

We now use the new ChildHooks instead of explicit options such
as setsid.


Diffs (updated)
-----

  src/docker/docker.cpp bb9ddde27464aa4d9215e3ca673fa87c6e00e326 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/slave/container_loggers/lib_logrotate.cpp 1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp 0576eab65a1f3556644472d5c9baba4ea9c34346 
  src/slave/containerizer/external_containerizer.cpp cf4384cce44172a028c890f52f71ceb8ae109383

  src/slave/containerizer/fetcher.cpp d5910ad570371ba54580be5bb94344a1de38d1f9 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259

  src/slave/containerizer/mesos/isolators/posix/disk.cpp dde958b252eae75563003ec15087b4231beb285a

  src/slave/containerizer/mesos/launcher.cpp a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
  src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66

  src/tests/containerizer/launch_tests.cpp 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 
  src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf

  src/tests/slave_tests.cpp 03bb6da687a1bf11d81619839e6730835e5c4d82 

Diff: https://reviews.apache.org/r/45492/diff/


Testing
-------

Tested entire chain see https://reviews.apache.org/r/45495/.


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message