mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.
Date Thu, 07 Apr 2016 10:59:29 GMT


> On March 22, 2016, 8:35 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, lines 41-43
> > <https://reviews.apache.org/r/45022/diff/1/?file=1305010#file1305010line41>
> >
> >     `RemoveDirectory` only works on empty directories, right? This seems to be consistent
with `rmdir`. Is this not true? Could you explain what the inconsistency is?

Hmm, inconsistent? It looks like the comment is saying that `rmdir` and `RemoveDirectory`
are consistent? Is the inconsistency elsewhere in another comment?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124879
-----------------------------------------------------------


On March 18, 2016, 7:39 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 7:39 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
>     https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 52568b303c03fd57b81f6cc67782444ce734dd41

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83

> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message