mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45067: Updated the long-lived-framework example.
Date Wed, 06 Apr 2016 18:33:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/#review127403
-----------------------------------------------------------


Fix it, then Ship it!





src/examples/long_lived_framework.cpp (line 155)
<https://reviews.apache.org/r/45067/#comment190696>

    no need for quotes around slaveId since it is generated by mesos and we know it doesn't
have spaces.



src/examples/long_lived_framework.cpp (line 163)
<https://reviews.apache.org/r/45067/#comment190697>

    // Helper to decline an offer.



src/examples/long_lived_framework.cpp (line 172)
<https://reviews.apache.org/r/45067/#comment190698>

    // Helper to launch a task using the offer.


- Vinod Kone


On April 5, 2016, 10:40 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45067/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 10:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5062
>     https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives the example `long-lived-framework` enough options to run outside of the build
environment.
> 
> This also updates:
> 
> * The style of the framework code.
> * Gives the `ExecutorInfo` some resources (needed for some cgroups isolators).
> * Restricts the framework to one agent.  Otherwise, it would grab a small chunk of every
machine in the cluster.
> * Adds filters for declined offers.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45067/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran this on the master node on a Mesos cluster:
> ```
> ./long-lived-framework --master=zk://localhost:2181/mesos --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor"
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message