mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 45594: Introduced a new agent flag docker_config.
Date Tue, 05 Apr 2016 19:28:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45594/#review127191
-----------------------------------------------------------




src/slave/flags.cpp (line 136)
<https://reviews.apache.org/r/45594/#comment190360>

    Can you probably elaborate a bit more why a docker config file configuration is needed?

    
    I know it's most likely for pulling private registry docker files, but not quite obvious
just by reading the help text.


- Timothy Chen


On April 5, 2016, 7:21 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45594/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5065
>     https://issues.apache.org/jira/browse/MESOS-5065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a new agent flag docker_config.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9ad0c2a201130ac23b22b1a844396dc97ec5ff70 
>   src/slave/flags.hpp 9ee7f349cc2bb3fa76141645f4a06fad57664367 
>   src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce 
> 
> Diff: https://reviews.apache.org/r/45594/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message