-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review127132
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto (line 32)
<https://reviews.apache.org/r/45270/#comment190273>
Does it should be repeated? And because the options looks like:
```
--volumeopts=k1=v1 --volumeopts=k2=v2
```
I think the type should be `Parameter`?
- haosdent huang
On April 2, 2016, 5:52 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 5:52 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added spec protobut for external mount.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced
> src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
> src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45270/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
|