mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45620: Adjusted the status semantics in CNI isolator.
Date Tue, 05 Apr 2016 16:37:42 GMT


> On April 2, 2016, 7:25 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 817
> > <https://reviews.apache.org/r/45620/diff/1/?file=1323273#file1323273line817>
> >
> >     We should have a comment here explaining why we are not returning a failure.
Primarily, because some containers might be on host network instead of CNI network.

Added a TODO. We should probably set ip addresses here for containers that join host network.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45620/#review126699
-----------------------------------------------------------


On April 2, 2016, 6:44 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45620/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4764
>     https://issues.apache.org/jira/browse/MESOS-4764
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch also does a few minor cleanups.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b1173d5adee6b4eb45dbed5e693f40ffb5275210

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621

> 
> Diff: https://reviews.apache.org/r/45620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message