mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.
Date Tue, 05 Apr 2016 03:44:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45726/#review127021
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 5, 2016, 2:57 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45726/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5114
>     https://issues.apache.org/jira/browse/MESOS-5114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 6313b6b1f535822e1dee39f5780895a3691ff78c

>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff

> 
> Diff: https://reviews.apache.org/r/45726/diff/
> 
> 
> Testing
> -------
> 
> Added a new test case that fails before the changes to `parse.hpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message