mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 45360: Added dvd client for mount and unmount.
Date Mon, 04 Apr 2016 23:37:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/#review126971
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp (line 33)
<https://reviews.apache.org/r/45360/#comment190092>

    s/DVDClient/DvdClient/g



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp (line 38)
<https://reviews.apache.org/r/45360/#comment190094>

    s/dvdCLIPath/dvdcliPath/g



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 54)
<https://reviews.apache.org/r/45360/#comment190097>

    `driver_options` is an optional field, right? This may lead to segfault.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 65)
<https://reviews.apache.org/r/45360/#comment190101>

    let's make it
    ```
    VLOG(1) << "Mount command '" << cmd << "'";
    ```



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (lines 67 - 71)
<https://reviews.apache.org/r/45360/#comment190106>

    could we set `dvdcliPath + /dvdcli` as cmd, and append the rest as argv?



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 77)
<https://reviews.apache.org/r/45360/#comment190105>

    Should we user await()?
    
    ```
    reutrn await(
        s.get().status(),
        io::read(s.get().out().get()),
        io::read(s.get().err().get()))
      .then(...)
    ```



src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp (line 86)
<https://reviews.apache.org/r/45360/#comment190107>

    ditto for umount.


- Gilbert Song


On April 1, 2016, 10:56 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45360/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 10:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added dvd client for mount and unmount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45360/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message