mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 45217: Implemented docker volume driver isolator interface.
Date Mon, 04 Apr 2016 23:01:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
-----------------------------------------------------------




src/Makefile.am (line 860)
<https://reviews.apache.org/r/45217/#comment189874>

    Could you move it below runtime.cpp?



src/Makefile.am (line 882)
<https://reviews.apache.org/r/45217/#comment189875>

    ditto.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 26)
<https://reviews.apache.org/r/45217/#comment189876>

    Could we add a brief comment above? Thanks.


- Gilbert Song


On April 1, 2016, 10:45 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 10:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented docker volume driver isolator interface.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45217/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message