mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45620: Adjusted the status semantics in CNI isolator.
Date Mon, 04 Apr 2016 21:42:20 GMT


> On April 3, 2016, 3:30 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 95
> > <https://reviews.apache.org/r/45620/diff/1/?file=1323272#file1323272line95>
> >
> >     Can you please clarify why making `networkInfo` as an `Option`? Is there any
chances that `status()` is called before `ContainerNetwork.networkInfo` is set in `prepare()`
and `_recover()`?

I was mainly thinking about the orphan container case. We still create 'Info' struct for orphan
containers. IN that case, the 'networkInfo' in the 'Info' struct does not make sense. Instead
of leaving a 'default' networkInfo, I prefer to be more explicit using Option.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45620/#review126713
-----------------------------------------------------------


On April 2, 2016, 6:44 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45620/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4764
>     https://issues.apache.org/jira/browse/MESOS-4764
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch also does a few minor cleanups.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b1173d5adee6b4eb45dbed5e693f40ffb5275210

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621

> 
> Diff: https://reviews.apache.org/r/45620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message