mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45461: Create tempfiles in test temporary directory.
Date Mon, 04 Apr 2016 21:39:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45461/#review126951
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On March 30, 2016, 5:26 p.m., Michael Browning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45461/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create tempfiles in test temporary directory.
> 
> Previously, some tests were creating tempfiles outside of the temporary directory created
by the test case and then manually removing them, which could lead to their being leaked if
the test were interrupted.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 84c8d487bbf61c77452bd293062a80fa132e069f 
> 
> Diff: https://reviews.apache.org/r/45461/diff/
> 
> 
> Testing
> -------
> 
> This change merely creates all temporary files used in the process of running fetcher
tests inside of the temp directories created by the test case, so no further testing was performed.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message