mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
Date Mon, 04 Apr 2016 20:30:58 GMT


> On March 18, 2016, 7:27 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118
> > <https://reviews.apache.org/r/44081/diff/1/?file=1298167#file1298167line118>
> >
> >     This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and below.
> 
> Alex Clemmer wrote:
>     That's right, but the only platform that's not true on is Windows, where this functionality
is not really available. Since we have no chance to generalize it to the Windows case, my
inclination is to keep it as is.

Sounds good.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
-----------------------------------------------------------


On March 31, 2016, 5:15 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44081/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b

> 
> Diff: https://reviews.apache.org/r/44081/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message