mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.
Date Mon, 04 Apr 2016 19:27:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126916
-----------------------------------------------------------


Ship it!




Thanks for doing this, I could easily imagine issues like this slipping throuh in the past
since I had to look trice :D

It might be a good idea to get these fixes in before the hook.

- Benjamin Bannier


On April 4, 2016, 5:22 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message