mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 45670: Added tests for HTTP command executor.
Date Mon, 04 Apr 2016 19:07:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review126904
-----------------------------------------------------------



hmm.. Would it be possible to not create a new file just for these two tests? IIUC, the existing
tests in `src/tests/command_executor_tests.cpp` can be easily parameterized by value. The
parameterization argument can be a boolean flag to the tests to enable/disable the HTTP based
executor. You can look at some possible examples in `SlaveRecoveryTest`/`SchedulerTest` for
possible examples.

In the near future, we would like to make `flags.http_command_executor=true` as the default
i.e. always run our test suite with this option set to `true`. I did a quick run using your
patches and there would be around ~20 tests mostly slave recovery tests that would need their
expectations modified. We can do that as part of a follow up JIRA later and not worry about
them for now.

- Anand Mazumdar


On April 4, 2016, 9:12 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/tests/http_command_executor_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message