-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/#review126839
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_spec_tests.cpp (line 112)
<https://reviews.apache.org/r/45621/#comment189935>
kill this one. `EXPECT_SOME_EQ` below will check that. Please fix all such cases.
- Jie Yu
On April 2, 2016, 8:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45621/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 8:20 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for docker spec helpers.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_spec_tests.cpp a0de305553cd21bcf266e902a73138862c348a4f
>
> Diff: https://reviews.apache.org/r/45621/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|