mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <>
Subject Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
Date Mon, 04 Apr 2016 15:21:35 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 4, 2016, 3:21 p.m.)

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.


Change the location of "+ 1" in chars for ease of readability.

Bugs: MESOS-4033

Repository: mesos


This patch adds an addition check in to check
for non-printable characters. It scans .cpp, .hpp, .cc, .h
files and reports an error if non-printable characters exist.

As part of this patch, two non-printable characters have been identified
in (one in Line 85 and another in Line 96) and are corrected

Note: Scanning .md files is skipped based on feedback from reviews.

Note: This commit includes patches from Kevin Klues and haosdent.

Diffs (updated)

  docs/ ecacd8433f0fa1643827b36d03154042538c1c6b 
  support/ 13616065ebe07ca401b385716d9b723f65bb2162 



Tested manually and found two non ascii characters in docs/ (fixed as part of
this review request).


Yong Tang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message