mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 45659: Fix non-printable chars in libprocess (format.hpp).
Date Sun, 03 Apr 2016 22:20:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126756
-----------------------------------------------------------


Ship it!




Only thing I'd suggest is to change the summary line to:

```
Changed some non-ascii characters in libprocess to their ascii equivalent.
```

- Kevin Klues


On April 3, 2016, 9:01 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters
> 
> This commit fix the non-printable characters in the following files:
> 
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp
> 
> Note: The commit hook requires separate commits for libprocess and mesos. That is why
this is a separate review request.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238

> 
> Diff: https://reviews.apache.org/r/45659/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message