mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 45660: Fix non-printable chars in mesos source code.
Date Sun, 03 Apr 2016 22:19:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126755
-----------------------------------------------------------


Ship it!




Looks great.  Glad we are finally able to catch these now!

Only comment would be on the summary line. We typically phrase the summary line in the past
tense, with a period at the end, i.e.:

```
Changed some non-ascii characters to ascii equivalent.
```

- Kevin Klues


On April 3, 2016, 9 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 9 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.
> 
> This commit fix the non-printable characters in the following files:
> src/slave/flags.cpp
> src/uri/fetchers/curl.cpp
> src/uri/fetchers/docker.cpp
> 
> Note: The commit hook requires separate commits for libprocess and mesos. That is why
this is a separate review request.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message