mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
Date Sun, 03 Apr 2016 20:43:37 GMT


> On April 3, 2016, 7:51 p.m., Kevin Klues wrote:
> > support/mesos-style.py, line 108
> > <https://reviews.apache.org/r/45033/diff/6/?file=1323542#file1323542line108>
> >
> >     I might have slipped it in a little late, but I also had a comment about the
actual matching going on here.
> >     
> >     This match doesn't exclude non-printable characters from the lower 127 ascii
codes, nor does it exclude unicode characters (which I think we want to exclude).
> >     
> >     I updated the patch I referenced before to include this.
> 
> Yong Tang wrote:
>     Thanks Kevin. Let me take a look and get this issue addressed.

Thanks Kevin. I updated the review request with the latest changes. As part of MESOS-4033,
I scan through the current source code and there are several .cpp and .hpp files that consists
of non-printable characters. They are:

3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp

src/slave/flags.cpp
src/uri/fetchers/curl.cpp
src/uri/fetchers/docker.cpp

I have to created two additional commits to change those non printable chars into printable
chars, as the current commit hook will not allow me to check in code that across both libprocess
and mesos. Those two commits are located:
https://reviews.apache.org/r/45659/
https://reviews.apache.org/r/45660/

Please take a look and let me know if there are any issues.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126749
-----------------------------------------------------------


On April 3, 2016, 8:36 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review request tries to add addition check in mesos-style.pl
> for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h
> files and report error if non-ascii characters exists.
> 
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
> 
> Note: .md scan is skipped based on feedback from review request.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -----
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and found two non ascii characters in docs/versioning.md (fixed as part
of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message