mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <>
Subject Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
Date Sun, 03 Apr 2016 20:36:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 3, 2016, 8:36 p.m.)

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.


Update review request and use Python's string.printable to detect non printable chars.

Bugs: MESOS-4033

Repository: mesos


This review request tries to add addition check in
for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h
files and report error if non-ascii characters exists.

As part of this review request, two non-ascii characters are identified
in (one in Ln 85 and another in Ln 96) and are corrected

Note: .md scan is skipped based on feedback from review request.

Note: This commit includes patches from Kevin Klues and haosdent.

Diffs (updated)

  docs/ ecacd8433f0fa1643827b36d03154042538c1c6b 
  support/ 13616065ebe07ca401b385716d9b723f65bb2162 



Tested manually and found two non ascii characters in docs/ (fixed as part of
this review request).


Yong Tang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message