mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.
Date Sun, 03 Apr 2016 13:42:45 GMT


> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 104
> > <https://reviews.apache.org/r/44441/diff/4/?file=1323253#file1323253line104>
> >
> >     Do we introduce 'arguments' flag? It looks like you treat 'command' flag as
command + arguments. This comment is misleading.

There is no `argument` flag now, I was following the comments here https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L427-L439
, the `command` will be composed by arguments and executable. What do you think? Do you think
we need to add a new flag `argument` for this? That may make the logic a bit complex for end
user.


> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 282
> > <https://reviews.apache.org/r/44441/diff/4/?file=1323253#file1323253line282>
> >
> >     Can we set `CommandInfo.value` outisde the loop and avoid this flag?

Here I need to get the first token as the value, so may not able to move this out of the loop,
do you have any other idea for moving this out?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126719
-----------------------------------------------------------


On 四月 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest
--containerizer=mesos --no-shell  --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting to register
without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message