mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anurag Singh <anurag.prakash.si...@gmail.com>
Subject Re: Review Request 44544: Moved contender and detector definitions into separate directories.
Date Fri, 01 Apr 2016 19:26:20 GMT


> On March 31, 2016, 5:25 p.m., Kapil Arya wrote:
> > src/master/contenders/contender.cpp, lines 58-61
> > <https://reviews.apache.org/r/44544/diff/9/?file=1308543#file1308543line58>
> >
> >     I am not sure if I understand this one here. Can you elaborate a bit?

Dropped this issue since this part of the code was copied verbatim.


- Anurag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44544/#review126329
-----------------------------------------------------------


On March 23, 2016, 11:05 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44544/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 11:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved contender and detector definitions into separate directories.
> 
> 
> Diffs
> -----
> 
>   src/master/contenders/contender.hpp PRE-CREATION 
>   src/master/contenders/contender.cpp PRE-CREATION 
>   src/master/detectors/detector.hpp PRE-CREATION 
>   src/master/detectors/detector.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44544/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message